tokers commented on issue #592:
URL:
https://github.com/apache/apisix-ingress-controller/issues/592#issuecomment-890503599
> > > First: Ingress Class has a default value ("apisix"). If you continue
to use ingressClass, then only ApisixRoute containing "apisix" will be listened
by default. And if you want to listen to all ApisixRoute CRD by default, it
seems impossible to achieve? Or put IngressClass To an empty string?
> > > Second: Does ApisixRoute CRD need to add the Spec.IngressClass field?
> >
> >
> > A tricky way to support listen all ApisixRoute CRs is reserving a
wildcard `*`, when the configured `ingressClass` is `*`, we listen all
ApisixRoutes.
> > I think add `spec.IngressClass` is a good way.
>
> Consider this scenario: At present, some people have used ApisixRoute CRD,
there is no ingressClass for isolation, so the default is to listen to all
ApisixRoute CRDs. But when they upgraded to the new ingress-controller version,
they found that by default Controller only listen to CRDs containing "apisix".
Is this situation unreasonable? Or change the default value of ingressClass to
"*"? But this will affect Ingress CRD.
As we already have similar logic about `IngressClass` resource, we may
respect it in other APISIX Ingress Controller CRDs, i.e. the default value of
`spec.ingrssClass` will be decided by the default IngressClass resource.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
