tokers commented on a change in pull request #609:
URL:
https://github.com/apache/apisix-ingress-controller/pull/609#discussion_r680498495
##########
File path: pkg/kube/apisix/apis/config/v2alpha1/types.go
##########
@@ -99,6 +100,7 @@ type ApisixRouteHTTP struct {
Backends []*ApisixRouteHTTPBackend `json:"backends"
yaml:"backends"`
Websocket bool `json:"websocket"
yaml:"websocket"`
Plugins []*ApisixRouteHTTPPlugin `json:"plugins,omitempty"
yaml:"plugins,omitempty"`
+ PluginConfigID string
`json:"plugin_config_id,omitempty" yaml:"plugin_config_id,omitempty"`
Review comment:
IMHO this is a terrible way to expose the ID of an APISIX configuration
in the declarative configuration way, it's not easy for people to configure it.
Another CRD to group a bunch of plugins can be introduced, say
`ApisixPluginConfig`, and here we should specify the name of such CR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
