tokers commented on a change in pull request #593:
URL:
https://github.com/apache/apisix-ingress-controller/pull/593#discussion_r680499147
##########
File path: cmd/ingress/ingress.go
##########
@@ -143,8 +143,7 @@ the apisix cluster and others are created`,
cmd.PersistentFlags().StringVar(&cfg.Kubernetes.Kubeconfig,
"kubeconfig", "", "Kubernetes configuration file (by default in-cluster
configuration will be used)")
cmd.PersistentFlags().DurationVar(&cfg.Kubernetes.ResyncInterval.Duration,
"resync-interval", time.Minute, "the controller resync (with Kubernetes)
interval, the minimum resync interval is 30s")
cmd.PersistentFlags().StringSliceVar(&cfg.Kubernetes.AppNamespaces,
"app-namespace", []string{config.NamespaceAll}, "namespaces that controller
will watch for resources")
- cmd.PersistentFlags().StringVar(&cfg.Kubernetes.IngressClass,
"ingress-class", config.IngressClass, "the class of an Ingress object is set
using the field IngressClassName in Kubernetes clusters version v1.18.0 or
higher or the annotation \"kubernetes.io/ingress.class\" (deprecated)")
- cmd.PersistentFlags().StringVar(&cfg.Kubernetes.ApisixRouteClass,
"apisix-route-class", config.ApisixRouteClass, "the class of an ApisixRoute
object is set using the field ApisixRouteClassName in Kubernetes")
Review comment:
This is a big broken change, we need some discussions in the mailing
list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
