Yiyiyimu commented on a change in pull request #4710:
URL: https://github.com/apache/apisix/pull/4710#discussion_r680569232
##########
File path: .github/workflows/build.yml
##########
@@ -89,7 +89,7 @@ jobs:
tar zxvf ${{ steps.branch_env.outputs.fullname }}
- name: Linux Get dependencies
- run: sudo apt install -y cpanminus build-essential libncurses5-dev
libreadline-dev libssl-dev perl
+ run: sudo apt install -y cpanminus build-essential libncurses5-dev
libreadline-dev libssl-dev perl libpcre3 libpcre3-dev
Review comment:
Sorry I made a mistake 😿 We need to add the dependency to the dockerfile
but not on the host machine. Do you mind file a PR about the change on the
dockerfile:
https://github.com/apache/apisix-docker/blob/master/alpine-local/Dockerfile,
which is used as building apisix image used in chaos testing
Also we need to change docs about dependencies installation to inform users
to install them:
https://github.com/apache/apisix/blob/master/docs/en/latest/install-dependencies.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
