tokers commented on a change in pull request #601:
URL:
https://github.com/apache/apisix-ingress-controller/pull/601#discussion_r680598894
##########
File path: pkg/apisix/cluster.go
##########
@@ -315,52 +317,74 @@ func (c *cluster) HasSynced(ctx context.Context) error {
}
}
-// syncSchema syncs schema from APISIX.
+// syncSchema syncs schema from APISIX regularly according to the interval.
+func (c *cluster) syncSchema(interval time.Duration) {
+ sigCh := make(chan os.Signal, 1)
+ signal.Notify(sigCh, syscall.SIGINT, syscall.SIGTERM)
Review comment:
> I think syncing the schema is a normal task to prevent the schema from
changing after the APISIX upgrade, which requires a regular task to run in the
background all the time. So this is not the same as syncCache.
This is by no means related to the signal handling stuff. Of course, we can
do it periodically. A Golang program should only have one place handling the
signals.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
