spacewander commented on a change in pull request #4633:
URL: https://github.com/apache/apisix/pull/4633#discussion_r681362436
##########
File path: t/plugin/error-log-logger.t
##########
@@ -281,7 +287,115 @@ passed
-=== TEST 9: want to reload the plugin by route
+=== TEST 9: log a warn level message (schema compatibility testing)
Review comment:
Better to add test at the end of file
##########
File path: docs/en/latest/plugins/error-log-logger.md
##########
@@ -30,31 +30,38 @@ title: error-log-logger
## Name
-`error-log-logger` is a plugin which pushes the log data of APISIX's error.log
to TCP servers.
+`error-log-logger` is a plugin which pushes the log data of APISIX's
`error.log` to TCP servers or [Apache
SkyWalking](https://skywalking.apache.org/).
-This plugin will provide the ability to send the log data which selected by
the level to Monitoring tools and other TCP servers.
+This plugin will provide the ability to send the log data which selected by
the level to Monitoring tools and other TCP servers, and SkyWalking over HTTP.
-This plugin provides the ability as a batch to push the log data to your
external TCP servers. If not receive the log data, don't worry, it will
automatically send the logs after the timer function expires in our Batch
Processor.
+This plugin provides the ability as a batch to push the log data to your
external TCP servers or monitoring tools. If not receive the log data, don't
worry, it will automatically send the logs after the timer function expires in
our Batch Processor.
For more info on Batch-Processor in Apache APISIX please refer.
[Batch-Processor](../batch-processor.md)
## Attributes
-| Name | Type | Requirement | Default | Valid | Description
|
-| ---------------- | ------- | ----------- | ------- | ------- |
----------------------------------------------------------------------------------------
|
-| host | string | required | | | IP address or
the Hostname of the TCP server. |
-| port | integer | required | | [0,...] | Target
upstream port.
|
-| timeout | integer | optional | 3 | [1,...] | Timeout for
the upstream to connect and send, unit: second.
|
-| keepalive | integer | optional | 30 | [1,...] | Time for
keeping the cosocket alive, unit: second.
|
-| level | string | optional | WARN | | The filter's
log level, default warn, choose the level in ["STDERR", "EMERG", "ALERT",
"CRIT", "ERR", "ERROR", "WARN", "NOTICE", "INFO", "DEBUG"], the value ERR
equals ERROR. |
-| tls | boolean | optional | false | | Control
whether to perform SSL verification
|
-| tls_server_name | string | optional | | | The server
name for the new TLS extension SNI
|
-| batch_max_size | integer | optional | 1000 | [1,...] | Max size of
each batch |
-| inactive_timeout | integer | optional | 3 | [1,...] | Maximum age
in seconds when the buffer will be flushed if inactive |
-| buffer_duration | integer | optional | 60 | [1,...] | Maximum age
in seconds of the oldest entry in a batch before the batch must be processed |
-| max_retry_count | integer | optional | 0 | [0,...] | Maximum
number of retries before removing from the processing pipe line
|
-| retry_delay | integer | optional | 1 | [0,...] | Number of
seconds the process execution should be delayed if the execution fails |
+| Name | Type | Requirement | Default
| Valid | Description
|
+| -------------------------------- | ------- | ----------- |
------------------------------ | ------- |
----------------------------------------------------------------------------------------------------
|
+| tcp.host | string | required |
| | IP address or the Hostname of the TCP server.
|
+| tcp.port | integer | required |
| [0,...] | Target upstream port.
|
+| tcp.tls | boolean | optional | false
| | Control whether to perform SSL verification.
|
+| tcp.tls_server_name | string | optional |
| | The server name for the new TLS extension SNI.
|
+| skywalking.endpoint_addr | string | required |
http://127.0.0.1:12900/v3/logs | | the http endpoint of Skywalking.
|
Review comment:
Once you provide a default value it is no longer required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
