tokers commented on a change in pull request #4654:
URL: https://github.com/apache/apisix/pull/4654#discussion_r681383061
##########
File path: t/chaos/killetcd/killetcd.go
##########
@@ -96,8 +96,23 @@ var _ = ginkgo.Describe("Test Get Success When Etcd Got
Killed", func() {
ginkgo.It("check if everything works", func() {
utils.SetRoute(e, httpexpect.Status2xx)
utils.GetRouteList(e, http.StatusOK)
- time.Sleep(1 * time.Second)
- utils.GetRoute(e, http.StatusOK)
+ var resp *httpexpect.Response
+
+ resp = utils.GetRouteIgnoreError(e)
+ // wait 1s seems not enough, wait some more time to make sure
nothing goes wrong
+ if resp.Raw().StatusCode != http.StatusOK {
Review comment:
Nope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
