okaybase commented on a change in pull request #613:
URL:
https://github.com/apache/apisix-ingress-controller/pull/613#discussion_r681393977
##########
File path: pkg/apisix/resource_test.go
##########
@@ -40,7 +40,10 @@ func TestItemUnmarshalJSON(t *testing.T) {
}
`
err = json.Unmarshal([]byte(emptyData), &items)
- assert.Equal(t, err.Error(), "unexpected non-empty object")
+ assert.True(t,
Review comment:
When err is nil, will trigger panic. Add nil value judgment to avoid
panic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
