liuxiran commented on issue #1933:
URL: 
https://github.com/apache/apisix-dashboard/issues/1933#issuecomment-895078562


   > > when we create a route with redirect plugin, does it still need 
enable_websocket param?
   > 
   > We don't need it.
   
   Thanks a lot @spacewander 
   
   then we have to update two points:
   
   1. when we bind service to a Route, we should pass `enable_websocket` 
normally to API.
   this can be tested by recheck `enable_websocket` value in the configure view
   
   2. when we enable  `redirect` in a Route, we should omit `enable_websocket` 
field in the create/configure step1.
   this can be tested by 
   2.1. when we enable `direct`, `enable_websocket` should not exist in the 
step1
   2.2 when we recheck the Route in the configure page, `enable_websocket` 
still not existed.
   
   @Baoyuantop 
   
   cc @juzhiyuan 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to