tzssangglass commented on a change in pull request #4759:
URL: https://github.com/apache/apisix/pull/4759#discussion_r685308683
##########
File path: t/plugin/consumer-restriction.t
##########
@@ -1476,7 +1476,242 @@ passed
-=== TEST 47: delete: route (id: 1)
+=== TEST 47: update consumer with plugin hmac-auth and consumer-restriction,
and set whitelist
+--- config
+ location /t {
+ content_by_lua_block {
+ local t = require("lib.test_admin").test
+ local code, body = t('/apisix/admin/consumers',
+ ngx.HTTP_PUT,
+ [[{
+ "username": "jack",
+ "plugins": {
+ "hmac-auth": {
+ "access_key": "my-access-key",
+ "secret_key": "my-secret-key"
+ },
+ "consumer-restriction": {
+ "type": "route_id",
+ "whitelist": [ "1" ],
+ "rejected_code": 401
+ }
+ }
+ }]],
+ [[{
+ "node": {
+ "value": {
+ "username": "jack",
+ "plugins": {
+ "hmac-auth": {
+ "access_key": "my-access-key",
+ "secret_key": "my-secret-key",
+ "algorithm": "hmac-sha256",
+ "clock_skew": 0
+ },
+ "consumer-restriction": {
+ "type": "route_id",
+ "whitelist": [ "1" ],
+ "rejected_code": 401
+ }
+ }
+ }
+ },
+ "action": "set"
+ }]]
+ )
+
+ ngx.status = code
+ ngx.say(body)
+ }
+ }
+--- request
+GET /t
+--- response_body
+passed
+--- no_error_log
+[error]
+
+
+
+=== TEST 48: verify: valid whitelist `route_id`
+--- config
+location /t {
+ content_by_lua_block {
+ local ngx_time = ngx.time
Review comment:
```suggestion
local ngx_time = ngx.time()
```
##########
File path: t/plugin/consumer-restriction.t
##########
@@ -1476,7 +1476,242 @@ passed
-=== TEST 47: delete: route (id: 1)
+=== TEST 47: update consumer with plugin hmac-auth and consumer-restriction,
and set whitelist
+--- config
+ location /t {
+ content_by_lua_block {
+ local t = require("lib.test_admin").test
+ local code, body = t('/apisix/admin/consumers',
+ ngx.HTTP_PUT,
+ [[{
+ "username": "jack",
+ "plugins": {
+ "hmac-auth": {
+ "access_key": "my-access-key",
+ "secret_key": "my-secret-key"
+ },
+ "consumer-restriction": {
+ "type": "route_id",
+ "whitelist": [ "1" ],
+ "rejected_code": 401
+ }
+ }
+ }]],
+ [[{
+ "node": {
+ "value": {
+ "username": "jack",
+ "plugins": {
+ "hmac-auth": {
+ "access_key": "my-access-key",
+ "secret_key": "my-secret-key",
+ "algorithm": "hmac-sha256",
+ "clock_skew": 0
+ },
+ "consumer-restriction": {
+ "type": "route_id",
+ "whitelist": [ "1" ],
+ "rejected_code": 401
+ }
+ }
+ }
+ },
+ "action": "set"
+ }]]
+ )
+
+ ngx.status = code
+ ngx.say(body)
+ }
+ }
+--- request
+GET /t
+--- response_body
+passed
+--- no_error_log
+[error]
+
+
+
+=== TEST 48: verify: valid whitelist `route_id`
+--- config
+location /t {
+ content_by_lua_block {
+ local ngx_time = ngx.time
+ local ngx_http_time = ngx.http_time
+ local core = require("apisix.core")
+ local t = require("lib.test_admin")
+ local hmac = require("resty.hmac")
+ local ngx_encode_base64 = ngx.encode_base64
+
+ local secret_key = "my-secret-key"
+ local timestamp = ngx_time()
+ local gmt = ngx_http_time(timestamp)
Review comment:
```suggestion
local gmt = ngx_http_time(ngx_time)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
