agile6v commented on a change in pull request #4814:
URL: https://github.com/apache/apisix/pull/4814#discussion_r688223869



##########
File path: apisix/cli/ngx_tpl.lua
##########
@@ -596,7 +596,7 @@ http {
             proxy_cache                         $upstream_cache_zone;
             proxy_cache_valid                   any {% if 
proxy_cache.cache_ttl then %} {* proxy_cache.cache_ttl *} {% else %} 10s {% end 
%};
             proxy_cache_min_uses                1;
-            proxy_cache_methods                 GET HEAD;
+            proxy_cache_methods                 GET HEAD POST;

Review comment:
       > Is it necessary to cache a POST request?
   > 
   > The only I can think of for caching POST requests is that some internal 
specification forces the consistent use of POST requests……
   
   Yes. This is a very rare scenario. The users don't enable the method on 
APISIX,  it doesn't take effect.  If users enable it, they need to know what 
they are doing.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to