spacewander commented on a change in pull request #4830:
URL: https://github.com/apache/apisix/pull/4830#discussion_r689379327
##########
File path: apisix/plugins/limit-count.lua
##########
@@ -188,7 +188,7 @@ function _M.access(conf, ctx)
if conf.allow_degradation then
return
end
- return 500, {error_msg = "failed to limit count: " .. err}
Review comment:
Let's fix the message above: `core.log.error("failed to limit req: ",
err)`
##########
File path: t/plugin/limit-count-redis2.t
##########
@@ -130,8 +130,6 @@ passed
GET /hello
--- error_code eval
500
---- response_body
Review comment:
Need to check error_log
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
