spacewander commented on a change in pull request #4845:
URL: https://github.com/apache/apisix/pull/4845#discussion_r690885793
##########
File path: apisix/plugins/authz-keycloak.lua
##########
@@ -83,6 +84,9 @@ local schema = {
{
properties = {
lazy_load_paths = {enum = {false}},
+ },
+ anyOf = {
+ {required = {"permissions"}}
Review comment:
We don't need to require it as we already provide a default value
##########
File path: t/plugin/authz-keycloak.t
##########
@@ -152,7 +152,33 @@ done
-=== TEST 6: full schema check
+=== TEST 6: no permissions when lazy_load_paths=false
Review comment:
Please add new test at the end
##########
File path: t/plugin/authz-keycloak.t
##########
@@ -152,7 +152,33 @@ done
-=== TEST 6: full schema check
+=== TEST 6: no permissions when lazy_load_paths=false
Review comment:
If I am correct, the previous code will be broken at
https://github.com/apache/apisix/blob/b72404f643f37b10eb164056d784c33a97251c46/apisix/plugins/authz-keycloak.lua#L591
even without reaching keyclock.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
