liuxiran commented on a change in pull request #2002:
URL: https://github.com/apache/apisix-dashboard/pull/2002#discussion_r693344371



##########
File path: web/src/components/Plugin/UI/basic-auth.tsx
##########
@@ -20,6 +20,7 @@ import { Form, Input } from 'antd';
 
 type Props = {
   form: FormInstance;
+  schema: Record<string, any> | undefined;

Review comment:
       nice, and then @wmdmomo  can try to dynamically adapt to the required 
props. which  the only rule for `basic-auth` plugin




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to