liuxiran commented on pull request #1984: URL: https://github.com/apache/apisix-dashboard/pull/1984#issuecomment-903421522
Hi @lookbrook , the code looks good to me, would you please add the related test case for this nice feature? you can refer to https://github.com/apache/apisix-dashboard/blob/9b18c35d3c61ccfb8c48bd458568c86ac902491e/web/cypress/integration/route/create-edit-duplicate-delete-route.spec.js#L105 to create a route with `buildin vars` and configure it, check if this rule seted successfully, and then change it to another param, check if it can configure successfully. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
