tzssangglass commented on a change in pull request #4876:
URL: https://github.com/apache/apisix/pull/4876#discussion_r693976352
##########
File path: apisix/plugins/kafka-logger.lua
##########
@@ -60,7 +59,8 @@ local schema = {
buffer_duration = {type = "integer", minimum = 1, default = 60},
inactive_timeout = {type = "integer", minimum = 1, default = 5},
batch_max_size = {type = "integer", minimum = 1, default = 1000},
- include_req_body = {type = "boolean", default = false}
+ include_req_body = {type = "boolean", default = false},
+ cluster_name = {type = "integer", default = 1},
Review comment:
> It confuses me, why name is an integer?
follow the origin design: https://github.com/doujiang24/lua-resty-kafka#new-1
```
The third optional cluster_name specifies the name of the cluster, default 1
(yeah, it's number). You can Specifies different names when you have two or
more kafka clusters. And this only works with async producer_type.
```
I think using numbers should satisfy the need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
