RedemptionC commented on pull request #2065: URL: https://github.com/apache/apisix-dashboard/pull/2065#issuecomment-904204863
> > > maybe we can assert the diff? like my latest commit did? > > > > > > but it seems that this is tesing the create API,not cache verify > > what part of cache_verify should we test in the e2e test? > > Why it's not cache verify? @nic-chen in the e2e test, I only check that `total` field in the cache verify response did increase by 3(which is the number of configs I created),I didn't check anything about consistency,becacuse I don't know how to make assertions on them: this is not mock,they can be consistent or inconsistent,I don't know what should I expect from them If you think the current implementation if OK,I can submit a clean version of them,and maybe then we can request more reviewers to see whether they deceide to approve this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
