liuxiran commented on pull request #2086: URL: https://github.com/apache/apisix-dashboard/pull/2086#issuecomment-904997313
cool, LGTM from code, thanks @wmdmomo As you will see from our past exchanges, test cases are important for a pr, a test case about: enable `basic-auth` plugin in consumer, check whether the username and password are required form field . This will help us merge your pr smoothly. Hope this example can help you: https://github.com/apache/apisix-dashboard/blob/master/web/cypress/integration/route/check-route-required-field-flag.spec.js -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
