gxthrj commented on a change in pull request #573:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/573#discussion_r695877878



##########
File path: test/e2e/scaffold/scaffold.go
##########
@@ -281,7 +281,8 @@ func (s *Scaffold) APISIXGatewayServiceEndpoint() string {
 
 func (s *Scaffold) beforeEach() {
        var err error
-       s.namespace = fmt.Sprintf("ingress-apisix-e2e-tests-%s-%d", 
s.opts.Name, time.Now().Nanosecond())
+       s.namespace = "ingress-apisix"
+       //s.namespace = fmt.Sprintf("ingress-apisix-e2e-tests-%s-%d", 
s.opts.Name, time.Now().Nanosecond())

Review comment:
       In e2e, every test scene has a namespace alone. It cannot be a constant, 
because test cases may run concurrently.
   
   The order of execution should be to generate namespace first and then certs.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to