wayne-cheng commented on a change in pull request #4881:
URL: https://github.com/apache/apisix/pull/4881#discussion_r696452968
##########
File path: apisix/cli/file.lua
##########
@@ -143,12 +165,11 @@ local function merge_conf(base, new_tab, ppath)
if base[key] == nil then
base[key] = val
elseif type(base[key]) ~= type_val then
- if (ppath == "nginx_config" or str_sub(ppath, 1, 14) ==
"nginx_config->") and
- (type_val == "number" or type_val == "string")
- then
+ local path = ppath == "" and key or ppath .. "->" .. key
Review comment:
@membphis The old code has been the schema like `ppath .. "->" ..
key`，and it used to print log. If change this to JSON，many test cases could be
affected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
