tzssangglass commented on a change in pull request #4856:
URL: https://github.com/apache/apisix/pull/4856#discussion_r700280676



##########
File path: t/cli/test_main.sh
##########
@@ -121,6 +121,54 @@ fi
 
 echo "passed: support multiple ports listen in http and https"
 
+# check support specific IP listen in http and https
+
+echo "
+apisix:
+  node_listen:
+    - ip: 127.0.0.1
+      port: 9081
+    - ip: 127.0.0.2
+      port: 9082
+      enable_http2: true
+  ssl:
+    enable_http2: false

Review comment:
       Is `enable_http2` here for backwards compatibility?

##########
File path: t/cli/test_main.sh
##########
@@ -121,6 +121,54 @@ fi
 
 echo "passed: support multiple ports listen in http and https"
 
+# check support specific IP listen in http and https
+
+echo "
+apisix:
+  node_listen:
+    - ip: 127.0.0.1
+      port: 9081
+    - ip: 127.0.0.2
+      port: 9082
+      enable_http2: true
+  ssl:
+    enable_http2: false

Review comment:
       I get




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to