tokers commented on a change in pull request #660:
URL:
https://github.com/apache/apisix-ingress-controller/pull/660#discussion_r701735253
##########
File path: Makefile
##########
@@ -104,6 +104,10 @@ ifeq ($(E2E_SKIP_BUILD), 0)
docker pull jmalloc/echo-server:latest
docker tag jmalloc/echo-server:latest
$(LOCAL_REGISTRY)/jmalloc/echo-server:latest
docker push $(LOCAL_REGISTRY)/jmalloc/echo-server:latest
+
+ docker pull busybox:1.28
+ docker tag busybox:1.28 $(LOCAL_REGISTRY)/busybox:1.28
+ docker push $(LOCAL_REGISTRY)/busybox:1.28
Review comment:
Please don't forget to modify helm chart.
##########
File path: test/e2e/scaffold/ingress.go
##########
@@ -217,7 +217,7 @@ spec:
initContainers:
- name: wait-apisix-admin
image: localhost:5000/busybox:1.28
- command: ['sh', '-c', "until nc -z
apisix-service-e2e-test.%s.svc.cluster.local 9080 ; do echo waiting for
apisix-admin; sleep 2; done;"]
+ command: ['sh', '-c', "until nc -z
apisix-service-e2e-test.%s.svc.cluster.local 9180 ; do echo waiting for
apisix-admin; sleep 2; done;"]
Review comment:
OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
