liuxiran commented on issue #2105:
URL: 
https://github.com/apache/apisix-dashboard/issues/2105#issuecomment-913872434


   
   > 1. I think we should keep the `put` method since we have the situation 
that specified the route ID.
   
   I am actually hesitant here, the fact that the ID is our unique identifier, 
customization increases flexibility while inviting the risk of duplication, In 
case the user defines two routes with duplicate IDs, using the PUT method, the 
latter will override the former. if I've missed any details, please point them 
out @starsz 
   
   > 2. The `delete` method should return the deleted route info?
   
   Other APIs were referenced during the design process
   
   * [Gthub 
API](https://docs.github.com/en/rest/reference/git#delete-a-reference) does not 
return the deleted info
   * [kubesphere 
API](https://kubesphere.io/api/kubesphere/#operation/DeletePipeline) does
   
   
   > 3. We will return the route info directly rather than including it in a 
field?
   
   for the get list API, infos will be included in a field called `items`, but 
for the info API, IMO we mainly want to get the route info, return them 
directly is a better way, what do you think?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to