spacewander commented on a change in pull request #4980:
URL: https://github.com/apache/apisix/pull/4980#discussion_r703110817
##########
File path: apisix/stream/router/ip_port.lua
##########
@@ -71,6 +96,20 @@ do
end
local route = item.value
+
+ if not item.value.remote_addr_matcher and item.value.remote_addr
then
+ local ip = create_matcher(item.value.remote_addr)
+ if ip then
Review comment:
We can write a new checker in
https://github.com/apache/apisix/blob/df0db95ce8f8a5a977481539b6af7e056d295680/apisix/stream/router/ip_port.lua#L185
to ensure the matcher can be always created?
We can use the methods in
https://github.com/apache/apisix/blob/master/apisix/core/ip.lua to do this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
