tokers commented on a change in pull request #143:
URL: https://github.com/apache/apisix-helm-chart/pull/143#discussion_r705307295
##########
File path: charts/apisix-ingress-controller/templates/deployment.yaml
##########
@@ -46,6 +46,10 @@ spec:
items:
- key: config.yaml
path: config.yaml
+ initContainers:
+ - name: wait-apisix-admin
+ image: busybox:1.28
+ command: ['sh', '-c', "until nc -z {{ .Values.admin.serviceName
}}.{{ .Release.Namespace }}.svc.cluster.local {{ .Values.admin.servicePort }} ;
do echo waiting for apisix-admin; sleep 2; done;"]
Review comment:
We'd better let users to specify the whole apisix admin service name
instead of assuming the service is deployed inside Kubernetes and the cluster
domain is `cluster.local`.
##########
File path: charts/apisix-ingress-controller/templates/deployment.yaml
##########
@@ -46,6 +46,10 @@ spec:
items:
- key: config.yaml
path: config.yaml
+ initContainers:
+ - name: wait-apisix-admin
+ image: busybox:1.28
Review comment:
Better to configure it by `.Values.initContainers[].image`, so that
users can know there is a dependency of busybox image.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
