arthur-zhang commented on a change in pull request #5038:
URL: https://github.com/apache/apisix/pull/5038#discussion_r706941186
##########
File path: apisix/plugins/hmac-auth.lua
##########
@@ -193,6 +206,19 @@ local function do_nothing(v)
return v
end
+local function validate_body(ctx, secret_key, params, req_body)
+ if not req_body then
+ req_body = ""
+ end
+ local digest_header = core.request.header(ctx, DIGEST)
+ if not digest_header then
+ -- it's ok if there is no digest header and no body
+ return req_body == ""
+ end
Review comment:
Maybe not, because we can omit digest header when body is empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
