tokers commented on a change in pull request #679:
URL:
https://github.com/apache/apisix-ingress-controller/pull/679#discussion_r707324692
##########
File path: test/e2e/ingress/webhook.go
##########
@@ -24,7 +24,7 @@ import (
"github.com/apache/apisix-ingress-controller/test/e2e/scaffold"
)
-var _ = ginkgo.Describe("Enable webhooks", func() {
+var _ = ginkgo.FDescribe("Enable webhooks", func() {
Review comment:
Please don't forget to revert his change before this PR merged.
##########
File path: pkg/apisix/schema.go
##########
@@ -63,7 +63,7 @@ func (sc schemaClient) getSchema(ctx context.Context, name
string) (*v1.Schema,
)
}
- url := sc.url + "/" + name
+ url := sc.url + name
Review comment:
OK, use `path.Join` is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
