RedemptionC commented on a change in pull request #2065: URL: https://github.com/apache/apisix-dashboard/pull/2065#discussion_r713192734
########## File path: api/cmd/cache_verify.go ########## @@ -0,0 +1,181 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package cmd + +import ( + "bytes" + "encoding/json" + "errors" + "fmt" + "io/ioutil" + "net/http" + "os" + + "github.com/spf13/cobra" + "github.com/tidwall/gjson" + + "github.com/apisix/manager-api/internal/conf" + "github.com/apisix/manager-api/internal/handler/cache_verify" + "github.com/apisix/manager-api/internal/log" +) + +var ( + port int + host, username, password string +) + +type response struct { + Data cache_verify.OutputResult `json:"data"` +} + +func newCacheVerifyCommand() *cobra.Command { + return &cobra.Command{ + Use: "cache-verify", + Short: "verify that data in cache are consistent with that in ETCD", + Run: func(cmd *cobra.Command, args []string) { + conf.InitConf() + log.InitLogger() + + port = conf.ServerPort + host = "127.0.0.1" Review comment: @starsz thanks for your review [@nic-chen suggested using localhost here](https://github.com/apache/apisix-dashboard/pull/2065#discussion_r706304751) I used to use `host = conf.ServerHost` @nic-chen said we shouldn't use that because it could be 0.0.0.0,I googled the difference between 0.0.0.0 and localhost,[see](https://stackoverflow.com/questions/20778771/what-is-the-difference-between-0-0-0-0-127-0-0-1-and-localhost) is it OK to use `host = conf.ServerHost`, or what do you think the host should be? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
