bzp2010 commented on a change in pull request #1946:
URL: https://github.com/apache/apisix-dashboard/pull/1946#discussion_r680320059
##########
File path: api/go.mod
##########
@@ -19,32 +18,27 @@ require (
github.com/gin-contrib/pprof v1.3.0
github.com/gin-contrib/static v0.0.0-20200916080430-d45d9a37d28e
github.com/gin-gonic/gin v1.6.3
- github.com/gogo/protobuf v1.3.2 // indirect
- github.com/golang/groupcache v0.0.0-20200121045136-8c9f03a8e57e //
indirect
github.com/google/uuid v1.1.2 // indirect
github.com/gorilla/websocket v1.4.2 // indirect
github.com/grpc-ecosystem/go-grpc-middleware v1.2.2 // indirect
- github.com/grpc-ecosystem/grpc-gateway v1.16.0 // indirect
github.com/jonboulle/clockwork v0.2.2 // indirect
- github.com/json-iterator/go v1.1.11 // indirect
github.com/prometheus/client_golang v1.8.0 // indirect
github.com/satori/go.uuid v1.2.0
github.com/shiningrush/droplet v0.2.6-0.20210127040147-53817015cd1b
github.com/shiningrush/droplet/wrapper/gin v0.2.1
github.com/sirupsen/logrus v1.7.0 // indirect
github.com/sony/sonyflake v1.0.0
github.com/spf13/cobra v0.0.3
- github.com/spf13/pflag v1.0.5 // indirect
+ github.com/spf13/viper v1.8.1
Review comment:
Hi, @moonming. Sorry to bother you again.
- I have read this specification
[https://www.apache.org/legal/resolved.html](https://www.apache.org/legal/resolved.html)
and made a query in JIRA, I found the following discussion, [LEGAL-562:
Handling dependency licenses for the Solr Operator, a go
project](https://issues.apache.org/jira/browse/LEGAL-562).
I think our situation is similar to that in the article. We do not include
the code under the MPL-2.0 license in the code distribution. The code is
downloaded by the user during the compilation process. In the docker image
involving binary distribution (It belongs to class B in the specification, and
we can distribute it using binary), we should modify the `LICENSE` and `NOTICE`
files and include them in the image as a reminder. Just like these project,
[apache/skywalking-banyandb](https://github.com/apache/skywalking-banyandb).
usage eg. in apache/skywalking-banyandb
[https://github.com/apache/skywalking-banyandb/blob/c6314fe15b56143836e8969bd756a1310779b3b0/go.mod#L20](https://github.com/apache/skywalking-banyandb/blob/c6314fe15b56143836e8969bd756a1310779b3b0/go.mod#L20)
- If we really can't include the dependencies of this library, can the above
scheme of replacing the dependent library code with shim?
[here](https://github.com/apache/apisix-dashboard/pull/1946#discussion_r670114961)
🤔 What do you think of this? Thx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
