nic-chen commented on a change in pull request #2010:
URL: https://github.com/apache/apisix-dashboard/pull/2010#discussion_r714426477
##########
File path: api/internal/filter/authentication.go
##########
@@ -90,7 +93,40 @@ func (mw *AuthenticationMiddleware) Handle(ctx
droplet.Context) error {
return nil
}
- if _, ok := conf.UserList[claims.Subject]; !ok {
+ userExist := false
+ switch conf.DataSourceType(claims.Audience) {
+ case conf.DataSourceTypeEtcd:
Review comment:
In my understanding, `local` should be written into etcd through yaml
configuration, and `external` is from third-party. It looks like `local` and
`etcd` are still different here? In this way, users configured in yaml cannot
be managed on the dashboard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
