bisakhmondal commented on pull request #2054: URL: https://github.com/apache/apisix-dashboard/pull/2054#issuecomment-927130469
Hi @bzp2010, thanks for the input. > But, with all due respect, the current management mode of service daemon and the use of system calls during use will undermine the compatibility of the operating system. Ideally, it might not be a good practice to use syscalls in the program but I don't think it would be a cause of some problem due to os compatibility (all the stable os kernels are written in C and assembly so libc is already there for handling syscalls). As for the context of current PR, it uses syscalls to ensure the pid that is written in `/tmp/manager-api.pid` is actually running or not. Please let me know if you have any alternatives. > Therefore, I think our finally goal should be to remove the service daemon management part from the Manager API and transfer it to the container or systemd, which is compatible with the container and RPM installation. Let professional software do professional things. I do not fully understand what you meant here. Just FYI and if I remember correctly, the current daemon management package for Manager API internally uses systemd (unit files with go templates) [[link](https://github.com/takama/daemon/blob/496d69192531c6cb1004380a0be0fcf2031b06f4/daemon_linux_systemd.go#L213-L227)]. > I don't understand service configuration, can you elaborate? I guess @starsz wanted to say configuration unit files (os dependent, like what I shared in the link) for different os service managers as you proposed to remove daemon management part from Manager API. Thanks :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
