spacewander commented on a change in pull request #5150:
URL: https://github.com/apache/apisix/pull/5150#discussion_r717377121



##########
File path: apisix/plugins/prometheus/exporter.lua
##########
@@ -153,6 +153,12 @@ function _M.log(conf, ctx)
         metrics.latency:observe(upstream_latency,
             gen_arr("upstream", route_id, service_id, consumer_name, 
balancer_ip))
         apisix_latency =  apisix_latency - upstream_latency
+
+        -- TODO: bug founded, ref to 
`https://github.com/apache/apisix/issues/5146`

Review comment:
       ```suggestion
           -- The latency might be negative, as Nginx uses different time 
measurements in
           -- different metrics. 
           -- See 
https://github.com/apache/apisix/issues/5146#issuecomment-928919399
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to