elvis-cai commented on pull request #5163: URL: https://github.com/apache/apisix/pull/5163#issuecomment-937736847
thanks for fixing the issue I raised in https://github.com/apache/apisix/issues/4906, did a quick test with this change, still using the same example route config from the issue, unfortunately, health check doesn't work as expected, adding some debug info, I found https://github.com/apache/apisix/pull/5163/files#diff-9af33577e041ece8fef32d8f8193f46eac83dab9e947a2cc940f36b83d5150e8R115 `hostheader` is always "httpbin.org", no matter upstream node domain is `apple.internal.com` or `banana.internal.com`. another test I did is still the same line https://github.com/apache/apisix/pull/5163/files#diff-9af33577e041ece8fef32d8f8193f46eac83dab9e947a2cc940f36b83d5150e8R115, use `node.domain` could output the correct host header for health checking. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
