leslie-tsang commented on a change in pull request #5200:
URL: https://github.com/apache/apisix/pull/5200#discussion_r726144560
##########
File path: ci/pod/nacos/service/Dockerfile
##########
@@ -0,0 +1,16 @@
+
Review comment:
BTW, I found it will cost 800m+ memory for this container. Is there a
way to reduce the memory cost?
##########
File path: Makefile
##########
@@ -15,14 +15,45 @@
# limitations under the License.
#
+# Makefile basic env setting
+.DEFAULT_GOAL := help
+# add pipefail support for default shell
+SHELL := /bin/bash -o pipefail
+
+
+# Project basic setting
+project_name ?= apache-apisix
+project_version ?= latest
+project_compose_ci ?= ci/pod/docker-compose.yml
+project_release_name ?= $(project_name)-$(project_version)-src
+
+
+# Hyperconverged Infrastructure
+ENV_OS_NAME ?= $(shell uname -s | tr '[:upper:]' '[:lower:]')
+ENV_OS_ARCH ?= $(shell uname -m | tr '[:upper:]' '[:lower:]')
+ENV_APISIX ?= $(CURDIR)/bin/apisix
+ENV_GIT ?= git
+ENV_DOCKER ?= docker
+ENV_DOCKER_COMPOSE ?= docker-compose --project-directory $(CURDIR) -p
$(project_name) -f $(project_compose_ci)
+ENV_NGINX ?= nginx -p $(CURDIR) -c $(CURDIR)/conf/nginx.conf
+
+
+# OSX archive `._` cache file
+ifeq ($(ENV_OS_NAME), darwin)
+ ENV_TAR ?= COPYFILE_DISABLE=1 tar
+else
+ ENV_TAR ?= tar
+endif
+
+
+# OLD VAR
INST_PREFIX ?= /usr
INST_LIBDIR ?= $(INST_PREFIX)/lib64/lua/5.1
INST_LUADIR ?= $(INST_PREFIX)/share/lua/5.1
INST_BINDIR ?= /usr/bin
INSTALL ?= install
-UNAME ?= $(shell uname)
-UNAME_MACHINE ?= $(shell uname -m)
OR_EXEC ?= $(shell which openresty || which nginx)
+LUAJIT_DIR ?= $(shell ${OR_EXEC} -V 2>&1 | grep prefix | grep -Eo
'prefix=(.*)/nginx\s+--' | grep -Eo '/.*/')luajit
Review comment:
Unused. can we remove it ?
##########
File path: ci/pod/nacos/service/Dockerfile
##########
@@ -0,0 +1,16 @@
+
Review comment:
@spacewander It may be better to use an apisix official docker image to
replace it.
Can APISIX community build an official docker hub image ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
