Xunzhuo commented on a change in pull request #5259:
URL: https://github.com/apache/apisix/pull/5259#discussion_r731467572
##########
File path: apisix/control/v1.lua
##########
@@ -193,7 +193,45 @@ function _M.dump_route_info()
return 200, route
end
+local function iter_add_get_upstream_info(values, upstream_id)
+ if not values then
+ return nil
+ end
+ local infos = {}
+ for _, upstream in core.config_util.iterate_values(values) do
+ local new_upstream = core.table.deepcopy(upstream)
+ core.table.insert(infos, new_upstream)
+ if new_upstream.value and new_upstream.value.parent then
+ new_upstream.value.parent = nil
+ end
+ -- check the upstream id
+ if upstream_id and upstream.value.id == upstream_id then
+ return new_upstream
+ end
+ end
+ if not upstream_id then
+ return infos
+ end
+ return nil
+end
+
+function _M.dump_all_upstreams_info()
+ local upstreams = get_upstreams()
+ local infos = iter_add_get_upstream_info(upstreams, nil)
+ return 200, infos
+end
+
+function _M.dump_upstream_info()
+ local upstreams = get_upstreams()
+ local uri_segs = core.utils.split_uri(ngx_var.uri)
+ local upstream_id = uri_segs[4]
+ local upstream = iter_add_get_upstream_info(upstreams, upstream_id)
+ if not upstream then
+ return 404, {error_msg = str_format("upstream[%s] not found",
upstream_id)}
Review comment:
If this will be changed, the error msg from routes should be changed in
this format too, so in my view, this is OK for me 😃
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
