tokers commented on a change in pull request #143:
URL: https://github.com/apache/apisix-helm-chart/pull/143#discussion_r731664704
##########
File path: charts/apisix-ingress-controller/values.yaml
##########
@@ -101,6 +101,18 @@ config:
resources: {}
+admin:
+ serviceName: apisix-admin
+ serviceNamespace: ingress-apisix
+ servicePort: 9180
+
+kubernetes:
+ clusterDomain: cluster.local
Review comment:
`clusterDomain` can be put at the top level, just like what bitnami
does:
https://github.com/bitnami/charts/blob/master/bitnami/etcd/values.yaml#L38.
##########
File path: charts/apisix-ingress-controller/values.yaml
##########
@@ -101,6 +101,18 @@ config:
resources: {}
+admin:
+ serviceName: apisix-admin
Review comment:
It's duplicated with the `config.kubernetes.apisix.baseURL`, could we
try to unify them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
