bzp2010 commented on a change in pull request #2104:
URL: https://github.com/apache/apisix-dashboard/pull/2104#discussion_r731803350



##########
File path: api/test/e2enew/base/base.go
##########
@@ -81,6 +82,19 @@ func APISIXExpect() *httpexpect.Expect {
        return httpexpect.New(t, APISIXHost)
 }
 
+func APISIXStreamProxyExpect(port uint16, isHTTPS bool) *httpexpect.Expect {
+       if port == 0 {
+               port = 10090
+       }
+       t := getTestingHandle()
+
+       if isHTTPS {
+               return httpexpect.New(t, "https://"; + 
net.JoinHostPort("127.0.0.1", strconv.Itoa(int(port))))
+       } else {
+               return httpexpect.New(t, "http://"; + 
net.JoinHostPort("127.0.0.1", strconv.Itoa(int(port))))
+       }
+}

Review comment:
       @nic-chen I have added a basic E2E test case, which still uses the HTTP 
server as the upstream service. The `test.com` domain name is used as the SNI 
name, and the test case baseURL generation method is improved. During 
execution, call the simulation upstream running in docker through this domain 
name and obtain the corresponding.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to