tao12345666333 commented on a change in pull request #143:
URL: https://github.com/apache/apisix-helm-chart/pull/143#discussion_r732024308
##########
File path: charts/apisix-ingress-controller/templates/deployment.yaml
##########
@@ -46,6 +46,10 @@ spec:
items:
- key: config.yaml
path: config.yaml
+ initContainers:
+ - name: wait-apisix-admin
+ image: {{ .Values.initContainer.image }}:{{.Values.initContainer.tag
}}
+ command: ['sh', '-c', "until nc -z {{
.Values.config.apisix.serviceName }}.{{ .Values.config.apisix.serviceNamespace
}}.svc.{{.Values.clusterDomain}} {{ .Values.config.apisix.servicePort }} ; do
echo waiting for apisix-admin; sleep 2; done;"]
Review comment:
```suggestion
command: ['sh', '-c', "until nc -z {{
.Values.config.apisix.serviceName }}.{{ .Values.config.apisix.serviceNamespace
}}.svc.{{ .Values.clusterDomain }} {{ .Values.config.apisix.servicePort }} ; do
echo waiting for apisix-admin; sleep 2; done;"]
```
##########
File path: charts/apisix-ingress-controller/templates/deployment.yaml
##########
@@ -46,6 +46,10 @@ spec:
items:
- key: config.yaml
path: config.yaml
+ initContainers:
+ - name: wait-apisix-admin
+ image: {{ .Values.initContainer.image }}:{{.Values.initContainer.tag
}}
Review comment:
```suggestion
image: {{ .Values.initContainer.image }}:{{
.Values.initContainer.tag }}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
