bisakhmondal commented on a change in pull request #5316:
URL: https://github.com/apache/apisix/pull/5316#discussion_r735147417
##########
File path: ci/centos7-ci.sh
##########
@@ -57,6 +57,10 @@ install_dependencies() {
# wait for grpc_server_example to fully start
sleep 3
+ # installing grpcurl
+ wget
https://github.com/fullstorydev/grpcurl/releases/download/v1.8.5/grpcurl_1.8.5_linux_x86_64.tar.gz
+ tar -xvf grpcurl_1.8.5_linux_x86_64.tar.gz -C /usr/local/bin
Review comment:
Sorry just now I realized, the common script (this is being sourced not
executed) has been used for exporting PATH variables and a ledger to store
version numbers as a single source. I think let's keep it that way only, a
logical separation. Let the CI of different os, execute the particular script
meant for that os. A future proof solution, haha : )
Let me know what do you think, Thanks!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
