starsz commented on a change in pull request #2183:
URL: https://github.com/apache/apisix-dashboard/pull/2183#discussion_r737945264
##########
File path: .github/workflows/backend-cli-test.yml
##########
@@ -45,6 +45,11 @@ jobs:
wget https://github.com/etcd-io/etcd/releases/download/v${{
matrix.etcd }}/etcd-v${{ matrix.etcd }}-linux-amd64.tar.gz
tar zxvf etcd-v${{ matrix.etcd }}-linux-amd64.tar.gz
+ - name: install bats
+ run: |
+ git clone https://github.com/sstephenson/bats.git && cd bats
Review comment:
The `bats` is archived.
Should we use it?
##########
File path: api/test/shell/dashboard.service
##########
@@ -0,0 +1,8 @@
+[Unit]
+Description=apisix-dashboard
+Conflicts=apisix-dashboard.service
+After=network-online.target
+
+[Service]
+WorkingDirectory=/usr/local/apisix/dashboard
+ExecStart=/usr/local/apisix/dashboard/manager-api -c
/usr/local/apisix/dashboard/conf/conf.yaml
Review comment:
Need EOL.
##########
File path: api/test/shell/dashboard.service
##########
@@ -0,0 +1,8 @@
+[Unit]
+Description=apisix-dashboard
+Conflicts=apisix-dashboard.service
+After=network-online.target
+
+[Service]
+WorkingDirectory=/usr/local/apisix/dashboard
+ExecStart=/usr/local/apisix/dashboard/manager-api -c
/usr/local/apisix/dashboard/conf/conf.yaml
Review comment:
We should add this file to the rpm package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
