tokers commented on a change in pull request #165:
URL: https://github.com/apache/apisix-helm-chart/pull/165#discussion_r738231780



##########
File path: charts/apisix/README.md
##########
@@ -103,6 +103,17 @@ Apache APISIX service parameters, this determines how 
users can access itself.
 | `admin.credentials.viewer` | Apache APISIX admin API viewer role credentials 
                                 | `4054f7cf07e344346cd3f287985e76a2`           
           |
 | `admin.allow.ipList`       | the IP range allowed to Apache APISIX admin API 
                                 | `true`                                       
           |
 
+### custom configuration snippet parameters
+
+| Parameter                        | Description                               
                | Default |
+|----------------------------------|-----------------------------------------------------------|---------|
+| `configurationSnippet.main`      | Add custom Nginx main configuration to 
nginx.conf         | {}      |
+| `configurationSnippet.httpStart` | Add custom Nginx http configuration to 
nginx.conf         | {}      |
+| `configurationSnippet.httpEnd`   | Add custom Nginx http end configuration 
to nginx.conf     | {}      |

Review comment:
       ```suggestion
   | `configurationSnippet.httpEnd`   | Add custom Nginx configuration (http 
block) to nginx.conf, will be put at the bottom of http block     | {}      |
   ```

##########
File path: charts/apisix/README.md
##########
@@ -103,6 +103,17 @@ Apache APISIX service parameters, this determines how 
users can access itself.
 | `admin.credentials.viewer` | Apache APISIX admin API viewer role credentials 
                                 | `4054f7cf07e344346cd3f287985e76a2`           
           |
 | `admin.allow.ipList`       | the IP range allowed to Apache APISIX admin API 
                                 | `true`                                       
           |
 
+### custom configuration snippet parameters
+
+| Parameter                        | Description                               
                | Default |
+|----------------------------------|-----------------------------------------------------------|---------|
+| `configurationSnippet.main`      | Add custom Nginx main configuration to 
nginx.conf         | {}      |

Review comment:
       ```suggestion
   | `configurationSnippet.main`      | Add custom Nginx configuration (main 
block) to nginx.conf         | {}      |
   ```

##########
File path: charts/apisix/README.md
##########
@@ -103,6 +103,17 @@ Apache APISIX service parameters, this determines how 
users can access itself.
 | `admin.credentials.viewer` | Apache APISIX admin API viewer role credentials 
                                 | `4054f7cf07e344346cd3f287985e76a2`           
           |
 | `admin.allow.ipList`       | the IP range allowed to Apache APISIX admin API 
                                 | `true`                                       
           |
 
+### custom configuration snippet parameters
+
+| Parameter                        | Description                               
                | Default |
+|----------------------------------|-----------------------------------------------------------|---------|
+| `configurationSnippet.main`      | Add custom Nginx main configuration to 
nginx.conf         | {}      |
+| `configurationSnippet.httpStart` | Add custom Nginx http configuration to 
nginx.conf         | {}      |

Review comment:
       ```suggestion
   | `configurationSnippet.httpStart` | Add custom Nginx configuration (http 
block) to nginx.conf         | {}      |
   ```

##########
File path: charts/apisix/README.md
##########
@@ -103,6 +103,17 @@ Apache APISIX service parameters, this determines how 
users can access itself.
 | `admin.credentials.viewer` | Apache APISIX admin API viewer role credentials 
                                 | `4054f7cf07e344346cd3f287985e76a2`           
           |
 | `admin.allow.ipList`       | the IP range allowed to Apache APISIX admin API 
                                 | `true`                                       
           |
 
+### custom configuration snippet parameters
+
+| Parameter                        | Description                               
                | Default |
+|----------------------------------|-----------------------------------------------------------|---------|
+| `configurationSnippet.main`      | Add custom Nginx main configuration to 
nginx.conf         | {}      |
+| `configurationSnippet.httpStart` | Add custom Nginx http configuration to 
nginx.conf         | {}      |
+| `configurationSnippet.httpEnd`   | Add custom Nginx http end configuration 
to nginx.conf     | {}      |
+| `configurationSnippet.httpSrv`   | Add custom Nginx http server 
configuration to nginx.conf  | {}      |

Review comment:
       ```suggestion
   | `configurationSnippet.httpSrv`   | Add custom Nginx configuration (server 
block) to nginx.conf  | {}      |
   ```

##########
File path: charts/apisix/README.md
##########
@@ -103,6 +103,17 @@ Apache APISIX service parameters, this determines how 
users can access itself.
 | `admin.credentials.viewer` | Apache APISIX admin API viewer role credentials 
                                 | `4054f7cf07e344346cd3f287985e76a2`           
           |
 | `admin.allow.ipList`       | the IP range allowed to Apache APISIX admin API 
                                 | `true`                                       
           |
 
+### custom configuration snippet parameters
+
+| Parameter                        | Description                               
                | Default |
+|----------------------------------|-----------------------------------------------------------|---------|
+| `configurationSnippet.main`      | Add custom Nginx main configuration to 
nginx.conf         | {}      |
+| `configurationSnippet.httpStart` | Add custom Nginx http configuration to 
nginx.conf         | {}      |
+| `configurationSnippet.httpEnd`   | Add custom Nginx http end configuration 
to nginx.conf     | {}      |
+| `configurationSnippet.httpSrv`   | Add custom Nginx http server 
configuration to nginx.conf  | {}      |
+| `configurationSnippet.httpAdmin` | Add custom Nginx admin server 
configuration to nginx.conf | {}      |

Review comment:
       ```suggestion
   | `configurationSnippet.httpAdmin` | Add custom Nginx configuration (Admin 
API server block) to nginx.conf | {}      |
   ```

##########
File path: charts/apisix/README.md
##########
@@ -103,6 +103,17 @@ Apache APISIX service parameters, this determines how 
users can access itself.
 | `admin.credentials.viewer` | Apache APISIX admin API viewer role credentials 
                                 | `4054f7cf07e344346cd3f287985e76a2`           
           |
 | `admin.allow.ipList`       | the IP range allowed to Apache APISIX admin API 
                                 | `true`                                       
           |
 
+### custom configuration snippet parameters
+
+| Parameter                        | Description                               
                | Default |
+|----------------------------------|-----------------------------------------------------------|---------|
+| `configurationSnippet.main`      | Add custom Nginx main configuration to 
nginx.conf         | {}      |
+| `configurationSnippet.httpStart` | Add custom Nginx http configuration to 
nginx.conf         | {}      |
+| `configurationSnippet.httpEnd`   | Add custom Nginx http end configuration 
to nginx.conf     | {}      |
+| `configurationSnippet.httpSrv`   | Add custom Nginx http server 
configuration to nginx.conf  | {}      |
+| `configurationSnippet.httpAdmin` | Add custom Nginx admin server 
configuration to nginx.conf | {}      |
+| `configurationSnippet.stream`    | Add custom Nginx stream configuration to 
nginx.conf       | {}      |

Review comment:
       ```suggestion
   | `configurationSnippet.stream`    | Add custom Nginx configuration (stream 
block) to nginx.conf       | {}      |
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to