leslie-tsang commented on a change in pull request #5385:
URL: https://github.com/apache/apisix/pull/5385#discussion_r740010223
##########
File path: utils/install-dependencies.sh
##########
@@ -24,10 +24,9 @@ function install_dependencies_with_yum() {
# add OpenResty source
sudo yum install yum-utils
sudo yum-config-manager --add-repo
"https://openresty.org/package/${1}/openresty.repo";
- sudo yum check-update
Review comment:
IMO, `yum check-update` check whether there is a update or not would't
bring any benefit for `install_dependencies_with_yum`.
`yum` don't need to update the repo cache after adding a new repo like `apt`
does.
Shall we remove it ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
