Xunzhuo commented on a change in pull request #5378:
URL: https://github.com/apache/apisix/pull/5378#discussion_r740946180
##########
File path: apisix/plugins/limit-count.lua
##########
@@ -36,11 +36,10 @@ local schema = {
properties = {
count = {type = "integer", exclusiveMinimum = 0},
time_window = {type = "integer", exclusiveMinimum = 0},
- key = {
- type = "string",
- enum = {"remote_addr", "server_addr", "http_x_real_ip",
- "http_x_forwarded_for", "consumer_name", "service_id"},
- default = "remote_addr",
+ key = {type = "string", default = "remote_addr"},
+ key_type = {type = "string",
+ enum = {"var", "var_combination"},
Review comment:
Thanks @tokers , if we keep the enum constraints for var like before, it
will be a problem to use var_combination, because var_combination provides a
more flexible way to key selecting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
