moonming commented on a change in pull request #5378:
URL: https://github.com/apache/apisix/pull/5378#discussion_r741900875
##########
File path: apisix/plugins/limit-count.lua
##########
@@ -36,11 +36,10 @@ local schema = {
properties = {
count = {type = "integer", exclusiveMinimum = 0},
time_window = {type = "integer", exclusiveMinimum = 0},
- key = {
- type = "string",
- enum = {"remote_addr", "server_addr", "http_x_real_ip",
- "http_x_forwarded_for", "consumer_name", "service_id"},
- default = "remote_addr",
+ key = {type = "string", default = "remote_addr"},
+ key_type = {type = "string",
+ enum = {"var", "var_combination"},
Review comment:
please add test cases for non-existent variable @Xunzhuo
##########
File path: apisix/plugins/limit-count.lua
##########
@@ -171,7 +170,29 @@ function _M.access(conf, ctx)
return 500
end
- local key = (ctx.var[conf.key] or "") .. ctx.conf_type .. ctx.conf_version
+ local conf_key = conf.key
+ local key
+ if conf.key_type == "var_combination" then
+ local err, n_resolved
+ key, err, n_resolved = core.utils.resolve_var(conf_key, ctx.var);
+ if err then
+ core.log.error("could not resolve vars in ", conf_key, " error: ",
err)
+ end
+
+ if n_resolved == 0 then
+ key = nil
+ end
+ else
+ key = ctx.var[conf_key]
Review comment:
if `ctx.var[conf_key]` is `nil`, what is the result you expect?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
