This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new e94c6ee chore: clean up outdated comments (#5459)
e94c6ee is described below
commit e94c6eef587887eb3a078aea3a74d5021b0dde65
Author: 罗泽轩 <[email protected]>
AuthorDate: Wed Nov 10 09:31:12 2021 +0800
chore: clean up outdated comments (#5459)
---
apisix/core/request.lua | 2 --
apisix/plugins/example-plugin.lua | 2 +-
apisix/plugins/limit-req.lua | 2 +-
apisix/plugins/proxy-rewrite.lua | 2 --
4 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/apisix/core/request.lua b/apisix/core/request.lua
index d5482e6..f098f63 100644
--- a/apisix/core/request.lua
+++ b/apisix/core/request.lua
@@ -198,8 +198,6 @@ end
function _M.get_body(max_size, ctx)
- -- TODO: improve the check with set client_max_body dynamically
- -- which requires to change Nginx source code
if max_size then
local var = ctx and ctx.var or ngx.var
local content_length = tonumber(var.http_content_length)
diff --git a/apisix/plugins/example-plugin.lua
b/apisix/plugins/example-plugin.lua
index f1d1cc3..07e8024 100644
--- a/apisix/plugins/example-plugin.lua
+++ b/apisix/plugins/example-plugin.lua
@@ -44,7 +44,7 @@ local plugin_name = "example-plugin"
local _M = {
version = 0.1,
- priority = 0, -- TODO: add a type field, may be a good idea
+ priority = 0,
name = plugin_name,
schema = schema,
metadata_schema = metadata_schema,
diff --git a/apisix/plugins/limit-req.lua b/apisix/plugins/limit-req.lua
index 824a47d..6439bf5 100644
--- a/apisix/plugins/limit-req.lua
+++ b/apisix/plugins/limit-req.lua
@@ -51,7 +51,7 @@ local schema = {
local _M = {
version = 0.1,
- priority = 1001, -- TODO: add a type field, may be a good idea
+ priority = 1001,
name = plugin_name,
schema = schema,
}
diff --git a/apisix/plugins/proxy-rewrite.lua b/apisix/plugins/proxy-rewrite.lua
index ca9210e..0780b21 100644
--- a/apisix/plugins/proxy-rewrite.lua
+++ b/apisix/plugins/proxy-rewrite.lua
@@ -199,8 +199,6 @@ function _M.rewrite(conf, ctx)
return
end
- -- reform header from object into array, so can avoid use pairs,
- -- which is NYI
if not conf.headers_arr then
conf.headers_arr = {}