windyrjc commented on a change in pull request #5501:
URL: https://github.com/apache/apisix/pull/5501#discussion_r749027979
##########
File path: t/plugin/kafka-logger.t
##########
@@ -1208,3 +1208,107 @@ hello world
--- error_log_like eval
qr/send data to kafka: \{.*"body":"abcdef"/
--- wait: 2
+
+
+
+=== TEST 28: hit route, not trigger request_body_expr rule
+--- request
+GET /hello
Review comment:
Ok, i just want to prove that if there was no request body, it still
work normally. There is already has a eval false case below and i'm delete this
case for good
##########
File path: t/plugin/kafka-logger.t
##########
@@ -1135,7 +1135,7 @@ qr/failed to send data to Kafka topic: .*, brokers:
\{"127.0.0.127":9092}/
"key" : "key1",
"timeout" : 1,
"include_req_body": true,
- "request_body_expr": [
+ "include_req_body_expr": [
[
"remote_addr",
Review comment:
I'm not understand what this means
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
