bzp2010 commented on a change in pull request #5518:
URL: https://github.com/apache/apisix/pull/5518#discussion_r753882776
##########
File path: t/core/request.t
##########
@@ -437,3 +437,31 @@ c=z_z&v=x%20x
nil
--- error_log
the post form is too large: request body in temp file not supported
+
+
+
+=== TEST 13: get_method
+--- config
+ location = /hello {
+ client_body_in_file_only clean;
Review comment:
https://github.com/apache/apisix/blob/93b33d8f5f4af73c621d52d017d114127593b936/apisix/plugins/openwhisk.lua#L72
This function is used here, and when I needed to use it, I realized that it
was not wrapped in our core library, which would mix up the use of `ngx.req`
and `core.request`, so I added this function and its tests.
##########
File path: t/core/request.t
##########
@@ -437,3 +437,31 @@ c=z_z&v=x%20x
nil
--- error_log
the post form is too large: request body in temp file not supported
+
+
+
+=== TEST 13: get_method
+--- config
+ location = /hello {
+ client_body_in_file_only clean;
Review comment:
https://github.com/apache/apisix/blob/93b33d8f5f4af73c621d52d017d114127593b936/apisix/plugins/openwhisk.lua#L72-L76
This function is used here, and when I needed to use it, I realized that it
was not wrapped in our core library, which would mix up the use of `ngx.req`
and `core.request`, so I added this function and its tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
