shuaijinchao commented on a change in pull request #5589:
URL: https://github.com/apache/apisix/pull/5589#discussion_r755631478



##########
File path: t/admin/health-check.t
##########
@@ -469,17 +434,64 @@ GET /t
             ngx.print(body)
         }
     }
---- request
-GET /t
 --- error_code: 400
 --- response_body
 {"error_msg":"invalid configuration: property \"upstream\" validation failed: 
property \"checks\" validation failed: object matches none of the requireds: 
[\"active\"] or [\"active\",\"passive\"]"}
---- no_error_log
-[error]
 
 
 
-=== TEST 13: number type timeout
+=== TEST 13: only active

Review comment:
       The purpose of this test is to verify that the default passive 
configuration will be added in the case of active only. I think this title 
description is not very accurate, what do you think?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to