tokers commented on a change in pull request #694:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/694#discussion_r755638329



##########
File path: pkg/kube/apisix/apis/config/v2beta2/types.go
##########
@@ -195,3 +195,40 @@ type ApisixRouteList struct {
        metav1.ListMeta `json:"metadata" yaml:"metadata"`
        Items           []ApisixRoute `json:"items,omitempty" 
yaml:"items,omitempty"`
 }
+
+// +genclient
+// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
+// +kubebuilder:subresource:status
+
+// ApisixPluginConfig is the Schema for the ApisixPluginConfig resource.
+// An ApisixPluginConfig is used to support a group of plugin configs
+type ApisixPluginConfig struct {
+       metav1.TypeMeta   `json:",inline" yaml:",inline"`
+       metav1.ObjectMeta `json:"metadata" yaml:"metadata"`
+
+       // Spec defines the desired state of ApisixPluginConfigSpec.
+       Spec   ApisixPluginConfigSpec `json:"spec" yaml:"spec"`
+       Status v2alpha1.ApisixStatus  `json:"status,omitempty" 
yaml:"status,omitempty"`
+}
+
+// ApisixPluginConfigSpec defines the desired state of ApisixPluginConfigSpec.
+type ApisixPluginConfigSpec struct {
+       // +kubebuilder:validation:MinLength=1
+       Desc string `json:"desc,omitempty" yaml:"desc,omitempty"`

Review comment:
       But we don't have such field for other objects, and so far no users 
report such demands, so I doubt the necessity of it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to