neverCase commented on a change in pull request #772:
URL:
https://github.com/apache/apisix-ingress-controller/pull/772#discussion_r756740654
##########
File path: pkg/apisix/plugin_test.go
##########
@@ -23,6 +23,7 @@ import (
"testing"
"github.com/apache/apisix-ingress-controller/pkg/metrics"
+
Review comment:
My local golangci-lint would print these warnings below:
```sh
golangci-lint run
pkg/apisix/plugin_test.go:25: File is not `goimports`-ed with -local
github.com/apache/apisix-ingress-controller (goimports)
"github.com/apache/apisix-ingress-controller/pkg/metrics"
pkg/apisix/schema_test.go:24: File is not `goimports`-ed with -local
github.com/apache/apisix-ingress-controller (goimports)
"github.com/apache/apisix-ingress-controller/pkg/metrics"
```
Finally, I found that if I split the imports then there no warnings left.
Maybe I should ignore it in the next commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
